[webkit-reviews] review granted: [Bug 85764] [Chromium] Move createMessagePortChannel to Platform.h : [Attachment 146012] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 09:52:44 PDT 2012

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 85764: [Chromium] Move createMessagePortChannel to Platform.h

Attachment 146012: Patch

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146012&action=review

> Source/WebKit/chromium/public/WebFrame.h:42
> +#include <public/WebMessagePortChannel.h>

The #includes in Source/WebKit/chromium/public should use forwarding headers,
like WebURL.h above.

> Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:123
>  PlatformMessagePortChannel::PlatformMessagePortChannel()

This whole class should probably move into WebCore.

More information about the webkit-reviews mailing list