[webkit-reviews] review granted: [Bug 88087] [SOUP] WebSoupRequestManager should handle loading errors and zero-length replies : [Attachment 145292] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 88087: [SOUP] WebSoupRequestManager should handle loading errors and
zero-length replies
https://bugs.webkit.org/show_bug.cgi?id=88087

Attachment 145292: Patch
https://bugs.webkit.org/attachment.cgi?id=145292&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145292&action=review


> Source/WebKit2/WebProcess/soup/WebSoupRequestManager.cpp:50
> +	   // If the struct contains a null request is because the request
failed.

Nit: request is -> request, it is

> Source/WebKit2/WebProcess/soup/WebSoupRequestManager.cpp:65
> +    GSimpleAsyncResult* releaseResult()

It would make sense for this to return a GRefPtr to avoid a leak.

> Source/WebKit2/WebProcess/soup/WebSoupRequestManager.cpp:147
> +    if (!data)
> +	   return;

Above you ASSERT data and here you return. Is there a situation where you
expect data to be null here?