[webkit-reviews] review granted: [Bug 87835] Change the volume slider to horizontal rendering for Chrome video controls : [Attachment 145698] Use this for review

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Silvia Pfeiffer
<silviapf at chromium.org>'s request for review:
Bug 87835: Change the volume slider to horizontal rendering for Chrome video
controls
https://bugs.webkit.org/show_bug.cgi?id=87835

Attachment 145698: Use this for review
https://bugs.webkit.org/attachment.cgi?id=145698&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145698&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests. (visual update will contain rebaselined tests)

Nit: the parenthetical comment should be part of the sentence (move the period
to the end of the line).

> Source/WebCore/ChangeLog:11
> +	   The Chrome video controls are receiving a visual update. The volume
slider is included into
> +	   the controls with horizontal rendering, the volume slider container
is removed. The visual

Nit: "... is included into the controls" -> "... is included in the controls"
or "... is moved into the controls" depending on what exactly you mean.