[webkit-reviews] review denied: [Bug 87672] [Qt] Add quirks for running the web process in a profiler shell, like valgrind : [Attachment 145449] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 09:09:52 PDT 2012


Tor Arne Vestbø <vestbo at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 87672: [Qt] Add quirks for running the web process in a profiler shell,
like valgrind
https://bugs.webkit.org/show_bug.cgi?id=87672

Attachment 145449: Patch
https://bugs.webkit.org/attachment.cgi?id=145449&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145449&action=review


> Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:110
> +	   commandLine = commandLine %
static_cast<QString>(executablePathOfWebProcess());

static_cast?

> Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:115
> +	   commandLine = commandLine %
static_cast<QString>(executablePathOfPluginProcess());

??


More information about the webkit-reviews mailing list