[webkit-reviews] review denied: [Bug 88334] Prefer higher specificify selectors for rule set keys : [Attachment 145805] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 07:55:48 PDT 2012


Darin Adler <darin at apple.com> has denied Joshua Peek <josh at joshpeek.com>'s
request for review:
Bug 88334: Prefer higher specificify selectors for rule set keys
https://bugs.webkit.org/show_bug.cgi?id=88334

Attachment 145805: Patch
https://bugs.webkit.org/attachment.cgi?id=145805&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for taking the time to do this. The code change looks like it’s a good
one.

Changes to WebKit need to include change log entries.

Changes that say they speed things up need to include a test case demonstrating
the speedup, or at least some test data showing what the effect of the change
was when measuring performance.


More information about the webkit-reviews mailing list