[webkit-reviews] review denied: [Bug 88411] FileAPI: If type consists of non-ASCII characters in Blob constructor, it should throw a SyntaxError. : [Attachment 146013] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Li Yin <li.yin at intel.com>'s
request for review:
Bug 88411: FileAPI: If type consists of non-ASCII characters in Blob
constructor, it should throw a SyntaxError.
https://bugs.webkit.org/show_bug.cgi?id=88411

Attachment 146013: Patch
https://bugs.webkit.org/attachment.cgi?id=146013&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146013&action=review


> Source/WebCore/bindings/js/JSBlobCustom.cpp:108
> +	       setDOMException(exec, SYNTAX_ERR);
> +	       return JSValue::encode(JSValue());

SYNTAX_ERR and SyntaxError are different. You need to use 'return
throwVMError(exec, createSyntaxError(exec, "..."));'

> Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp:106
> +	       return throwError(SYNTAX_ERR, args.GetIsolate());

Ditto. You need to use 'return V8Proxy::throwError(V8Proxy::SyntaxError,
"...");'