[webkit-reviews] review denied: [Bug 87975] Web Inspector: [JSC] Add WebGL instrumentation support : [Attachment 145965] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 04:02:50 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 87975: Web Inspector: [JSC] Add WebGL instrumentation support
https://bugs.webkit.org/show_bug.cgi?id=87975

Attachment 145965: Patch
https://bugs.webkit.org/attachment.cgi?id=145965&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145965&action=review


> Source/WebCore/bindings/js/JSInjectedScriptManager.cpp:91
> +ScriptObject InjectedScriptManager::injectWebGLScript(const String& source,
ScriptObject glContext)

You should pass ScriptObject by reference (both here and in v8).


More information about the webkit-reviews mailing list