[webkit-reviews] review requested: [Bug 88340] [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient : [Attachment 145944] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 5 23:35:25 PDT 2012
Christophe Dumez <christophe.dumez at intel.com> has asked for review:
Bug 88340: [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=88340
Attachment 145944: Patch
https://bugs.webkit.org/attachment.cgi?id=145944&action=review
------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
- Rename title() method to action(): Was a bad copy/paste.
- Rename mimeType() method to payloadType(): Since type() is already taken, I
think it is better but feel free to suggest something better.
- Add payload data, extras hashmap and suggestion URLs to IntentData (only
MessagePorts are missing now but I'd like to do that in a separate patch)
More information about the webkit-reviews
mailing list