[webkit-reviews] review denied: [Bug 84597] InsertUnorderedList and InsertOrderedList (execCommand) do not remove bullets : [Attachment 145788] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 84597: InsertUnorderedList and InsertOrderedList (execCommand) do not
remove bullets
https://bugs.webkit.org/show_bug.cgi?id=84597

Attachment 145788: Patch
https://bugs.webkit.org/attachment.cgi?id=145788&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145788&action=review


r- because we need a test for this.

> Source/WebCore/ChangeLog:13
> +	   Comparison between start and end VisiblePositions is not proper
since the end
> +	   VisiblePosition also contains the offset, whereas comparison is made
with a
> +	   VisiblePosition which is at the start of the paragraph being
compared i.e. with
> +	   offset always as zero.

This isn't really accurate description of what's happening. The problem is that
we're sometimes comparing a position inside a paragraph with a position at the
start of the paragraph.