[webkit-reviews] review granted: [Bug 88349] Plumb CORS attribute information from HTMLMediaElement to media players so it can be used : [Attachment 145876] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 5 15:13:32 PDT 2012


Adam Barth <abarth at webkit.org> has granted Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 88349: Plumb CORS attribute information from HTMLMediaElement to media
players so it can be used
https://bugs.webkit.org/show_bug.cgi?id=88349

Attachment 145876: Patch
https://bugs.webkit.org/attachment.cgi?id=145876&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145876&action=review


Looks fine, with one naming nit.  Once you land the Chromium-side change, can
you write a test that shows the crossorigin attribute working correctly?

> Source/WebCore/ChangeLog:8
> +	   No new tests; do we have a version of http/tests supporting
different origins?

Yes.  Take a look in LayoutTests/http for tests related to access control
and/or CORS.  We also have tests for the crossorigin atribute for img.

> Source/WebCore/platform/graphics/MediaPlayer.h:104
> +    enum CrossOriginAttribute { Unspecified, Anonymous, UseCredentials };

CrossOriginAttribute => CORSMode ?


More information about the webkit-reviews mailing list