[webkit-reviews] review denied: [Bug 88310] [Qt][Win] Fix UString related build problem in Source/WebCore/bridge/qt/qt_instance.cpp : [Attachment 145782] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 88310: [Qt][Win] Fix UString related build problem in
Source/WebCore/bridge/qt/qt_instance.cpp
https://bugs.webkit.org/show_bug.cgi?id=88310

Attachment 145782: Patch
https://bugs.webkit.org/attachment.cgi?id=145782&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
So what's happening here is that method.methodSignature() returns a QByteArray
(latin1 encoded string), that is converted to a utf-16 encoded QString, which
is then supposed to get converted to a UString - except that the compiler is
confused.

Fortunately UString supports also latin1 encoded 8-bit strings, so I think the
much simpler fix is to avoid conversion from 8-bit latin1 to utf-16 and instead
construct the UString straight from 8-bit, i.e.
    QByteArray sig = method.methodSignature();
    .... UString(sig.constData(), sig.length());