[webkit-reviews] review denied: [Bug 88308] [Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp : [Attachment 145814] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 5 14:08:54 PDT 2012


Simon Hausmann <hausmann at webkit.org> has denied Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 88308: [Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=88308

Attachment 145814: Patch
https://bugs.webkit.org/attachment.cgi?id=145814&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Hm no, if we were using QT += widgets in WebCore, then this would not be
needed. But we shouldn't use QT += widgets in WebCore, so the question is: Why
dos PluginViewWin.cpp need QWidget?

I have the feeling that for Qt 5 it's not actually QWidget that's needed but
QWindow instead, to make the resolution from the WebView to a HWND.


More information about the webkit-reviews mailing list