[webkit-reviews] review granted: [Bug 88351] Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test : [Attachment 145846] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 5 12:01:00 PDT 2012


Levi Weintraub <leviw at chromium.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 88351: Change fast/sub-pixel/float-containing-block-with-margin.html to
pixel test
https://bugs.webkit.org/show_bug.cgi?id=88351

Attachment 145846: Patch
https://bugs.webkit.org/attachment.cgi?id=145846&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145846&action=review


> LayoutTests/ChangeLog:9
> +	   Change fast/sub-pixel/float-containing-block-with-margin.html to
pixel
> +	   test to allow for platform differences.

It makes me a saaaaad panda to see tests go backwards here, but I get it.
Perhaps a little more info would be handy?

> LayoutTests/ChangeLog:15
> +	   * fast/sub-pixel/float-containing-block-with-margin-expected.html:
Removed.
> +	   * fast/sub-pixel/float-containing-block-with-margin-expected.png:
Added.
> +	   * fast/sub-pixel/float-containing-block-with-margin-expected.txt:
Added.
> +	   * fast/sub-pixel/float-containing-block-with-margin.html:
> +	   *
platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expecte
d.png: Added.

Windows?


More information about the webkit-reviews mailing list