[webkit-reviews] review granted: [Bug 88328] Fix border-image-slice failures on http://css3test.com. : [Attachment 145775] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 88328: Fix border-image-slice failures on http://css3test.com.
https://bugs.webkit.org/show_bug.cgi?id=88328

Attachment 145775: Patch
https://bugs.webkit.org/attachment.cgi?id=145775&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145775&action=review


>
LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-slice.html:
22
> +var testValues = [ "10", "30%", "10 10", "10 30%", "30% 30%", "10 10 10",
"30% 10 10", "10 30% 10", "30% 30% 30% 10", "10 10 10 10", "30% 30% 30% 10",
"30% 30% 30% 30%", "fill 30%", "fill 10", "fill 2 4 8% 16%",
> +				   "30% fill", "10 fill", "2 4 8% 16% fill",
"10 fill 10", "solid", "fill fill" ];

Nit: weird indent

>
LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-slice.html:
25
> +var expectedValues = [ "'10'", "'30%'", "'10'", "'10 30%'", "'30%'", "'10'",
"'30% 10 10'", "'10 30%'", "'30% 30% 30% 10'", "'10'", "'30% 30% 30% 10'",
"'30%'", "'30% fill'", "'10 fill'", "'2 4 8% 16% fill'",
> +				   "'30% fill'", "'10 fill'", "'2 4 8% 16%
fill'", "'100%'", "'100%'", "'100%'" ];

Nit: weird indent

>
LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-slice.html:
28
> +e.style.borderImageSlice = "";

Nit: bad indent

>
LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-slice.html:
31
> +   
shouldBe("computedStyle.getPropertyCSSValue('border-image-slice').toString()",
"'[object CSSValue]'");

Nit: Is it useful to verify that it's a CSSValue?  This seems redundant to
getting cssText.