[webkit-reviews] review denied: [Bug 88273] nrwt should look in 'out' for binaries on chromium win to support ninja : [Attachment 145670] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 5 09:52:33 PDT 2012


Tony Chang <tony at chromium.org> has denied  review:
Bug 88273: nrwt should look in 'out' for binaries on chromium win to support
ninja
https://bugs.webkit.org/show_bug.cgi?id=88273

Attachment 145670: Patch
https://bugs.webkit.org/attachment.cgi?id=145670&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145670&action=review


> Tools/ChangeLog:3
> +	   nrwt should look in 'out' for binaries on chromium win to support
ninja

With this change, mac, linux, and win all look in 'out' (sometimes first,
sometimes second).  It would be nice if we pushed the out logic up into
chromium.py.


More information about the webkit-reviews mailing list