[webkit-reviews] review granted: [Bug 88292] [GTK] Build fix for Accelerated Compositing with OpenGL : [Attachment 145709] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 5 08:10:04 PDT 2012
Martin Robinson <mrobinson at webkit.org> has granted Joone Hur
<joone at webkit.org>'s request for review:
Bug 88292: [GTK] Build fix for Accelerated Compositing with OpenGL
https://bugs.webkit.org/show_bug.cgi?id=88292
Attachment 145709: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=145709&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145709&action=review
Looks good, but please fix the include order when landing.
> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h:28
> +
> +#if USE(GRAPHICS_SURFACE)
> #include "GraphicsSurface.h"
> +#endif
> +
You should now move this include below the rest of them, so it should be like:
#include "FloatRect.h"
#include "Image.h"
#include "TextureMapper.h"
#include "TextureMapperPlatformLayer.h"
#include <wtf/RefPtr.h>
#if USE(GRAPHICS_SURFACE)
#include "GraphicsSurface.h"
#endif
> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:28
> #include "GraphicsContext.h"
> +
> +#if USE(GRAPHICS_SURFACE)
> #include "GraphicsSurface.h"
> +#endif
> +
The same thing is necessary here.
More information about the webkit-reviews
mailing list