[webkit-reviews] review granted: [Bug 78720] [Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES : [Attachment 145737] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Roland Takacs
<rtakacs at inf.u-szeged.hu>'s request for review:
Bug 78720: [Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=78720

Attachment 145737: patch
https://bugs.webkit.org/attachment.cgi?id=145737&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145737&action=review


Great! One nitpick.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:240
> +#if !USE(OPENGL_ES_2)
>      glBindFramebuffer(GL_READ_FRAMEBUFFER_EXT, m_context->m_multisampleFBO);

>      glBindFramebuffer(GL_DRAW_FRAMEBUFFER_EXT, m_context->m_fbo);
> +#endif
>      glBlitFramebuffer(0, 0, m_context->m_currentWidth,
m_context->m_currentHeight, 0, 0, m_context->m_currentWidth,
m_context->m_currentHeight, GL_COLOR_BUFFER_BIT, GL_LINEAR);

The #endif should encompass the blit as well, we can't blit if we don't bind
READ/DRAW fbos.