[webkit-reviews] review denied: [Bug 88304] [Qt][Win] Fix IDL dependency generation : [Attachment 145771] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 88304: [Qt][Win] Fix IDL dependency generation
https://bugs.webkit.org/show_bug.cgi?id=88304

Attachment 145771: Patch
https://bugs.webkit.org/attachment.cgi?id=145771&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145771&action=review


> Source/WebCore/DerivedSources.pri:685
> +    # We need "$$binding " instead of "$$binding", because Windows' echo
writes trailing whitespaces. (http://wkb.ug/88304)

Isn't the case that we need "$$binding", not "$$binding " with trailing space?

> Source/WebCore/DerivedSources.pri:686
> +    preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP $$EOC

Can this be done by quoting instead?