[webkit-reviews] review requested: [Bug 88275] [Forms] Introduce InputNumber type as an alias of double for replacing it to Decimal : [Attachment 145711] Patch 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 5 00:39:14 PDT 2012
yosin at chromium.org has asked for review:
Bug 88275: [Forms] Introduce InputNumber type as an alias of double for
replacing it to Decimal
https://bugs.webkit.org/show_bug.cgi?id=88275
Attachment 145711: Patch 1
https://bugs.webkit.org/attachment.cgi?id=145711&action=review
------- Additional Comments from yosin at chromium.org
* Build locally with enabling all input types.
* EWS bots are too busy.
Could you review this patch?
Thanks in advance.
P.S.
It seems this patch is too big, however, replacing InputType to Decimal patch
will be smaller. I expect to touch following files only:
1. Decimal.cpp - for convertDoubleToInputType, convertInputTypeToDouble
2. Decimal.h - for convertDoubleToInputType, convertInputTypeToDouble
3. InputType.cpp - for applyStep and stepFromRenderer
4. InputType.h - for removing parseNumberWithDecimalPlaces
2. NumberInputType.cpp - for removing parseNumberWithDecimalPlaces and changing
sizeShouldIncludeDecoration.
3. StepRange.cpp - for alignValueForStep, parseStep and stepMismatch
More information about the webkit-reviews
mailing list