[webkit-reviews] review granted: [Bug 88285] Move some function definitions in EmptyClients.h to EmptyClients.cpp : [Attachment 145687] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 4 21:06:24 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 88285: Move some function definitions in EmptyClients.h to EmptyClients.cpp
https://bugs.webkit.org/show_bug.cgi?id=88285
Attachment 145687: Patch
https://bugs.webkit.org/attachment.cgi?id=145687&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145687&action=review
> Source/WebCore/loader/EmptyClients.cpp:65
> +// ----------------------------------------------------------------
I don't think we need these separators.
> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:38
> #include "FocusController.h"
Can we also remove this?
> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:45
> #include "WebInputEvent.h"
> #include "WebInputEventConversion.h"
And these?
More information about the webkit-reviews
mailing list