[webkit-reviews] review denied: [Bug 88283] JSC:need to implement Dictionary::getWithUndefinedOrNullCheck for IDB : [Attachment 145684] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 4 20:43:53 PDT 2012


Kentaro Hara <haraken at chromium.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 88283: JSC:need to implement Dictionary::getWithUndefinedOrNullCheck for
IDB
https://bugs.webkit.org/show_bug.cgi?id=88283

Attachment 145684: Patch
https://bugs.webkit.org/attachment.cgi?id=145684&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145684&action=review


> Source/WebCore/bindings/js/Dictionary.cpp:82
> +bool Dictionary::getWithUndefinedOrNullCheck(const String& propertyName,
String& value) const

This method should behave the same as get() except that
getWithUndefinedOrNullCheck() returns false if value is undefined or null.
Please refer to bindings/v8/Dictionary.{h,cpp}.


More information about the webkit-reviews mailing list