[webkit-reviews] review granted: [Bug 73176] Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'. : [Attachment 145541] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 4 20:19:51 PDT 2012


Adam Barth <abarth at webkit.org> has granted Dongwoo Joshua Im (dwim)
<dw.im at samsung.com>'s request for review:
Bug 73176: Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
https://bugs.webkit.org/show_bug.cgi?id=73176

Attachment 145541: Patch
https://bugs.webkit.org/attachment.cgi?id=145541&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145541&action=review


Great!	Thanks.

> Source/WebCore/page/NavigatorRegisterProtocolHandler.idl:-23
> -	   Conditional=REGISTER_PROTOCOL_HANDLER,

I would have left this as
Conditional=REGISTER_PROTOCOL_HANDLER|CUSTOM_SCHEME_HANDLER, but this is fine
too.


More information about the webkit-reviews mailing list