[webkit-reviews] review granted: [Bug 88000] Block selection gaps and inline selection heights are not properly pixel snapped : [Attachment 145650] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 88000: Block selection gaps and inline selection heights are not properly
pixel snapped
https://bugs.webkit.org/show_bug.cgi?id=88000

Attachment 145650: Patch
https://bugs.webkit.org/attachment.cgi?id=145650&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145650&action=review


r=me once my points are addressed :)

> Source/WebCore/ChangeLog:14
> +	   We were also unintentionally upcasting LayoutUnits to floats in
InlineTextBox's selection painting
> +	   routine. Now we're properly rounding.

It would be great to explain why the previous approach was wrong so that other
people don't have to figure it out by themselves.

Here's a nice joke that can go along with it:

In one of undergraduate math. classes at Berkeley, a professor was proving a
theorem.
In the proof, he said "X is obviously Y, and therefore Z" where X, Y, and Z
were some formal statements.
Students were puzzled because it wasn't obvious at all that Y followed X so one
of them asked the professor why it was obvious.
"because...", says the professor; he then paused for a second and asked himself
"Hm... wait, why is that...".
He spent the next 5 minutes thinking about it without a word, and then
concluded his answer by "uh huh! It IS obvious"
without explaining why it was obvious to students.
The only thing students understood was that they never have to prove Y follows
X in his class.