[webkit-reviews] review denied: [Bug 88270] EventHandler shouldn't dispatch fake mouse events on devices that don't have a mouse : [Attachment 145660] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 4 17:24:47 PDT 2012
James Robinson <jamesr at chromium.org> has denied Adam Barth
<abarth at webkit.org>'s request for review:
Bug 88270: EventHandler shouldn't dispatch fake mouse events on devices that
don't have a mouse
https://bugs.webkit.org/show_bug.cgi?id=88270
Attachment 145660: Patch
https://bugs.webkit.org/attachment.cgi?id=145660&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
Alex raises a good point about dynamically changing - Settings is normally
something that can't change over the lifetime of a Page, but this definitely
does need to change. That indicates that it probably should be routed in a
different way.
A similar argument could apply (although it's much less common) to
deviceSupportsTouch - someone _could_ plug a touchscreen monitor in while a
browser is running, but that seems pretty far fetched.
More information about the webkit-reviews
mailing list