[webkit-reviews] review denied: [Bug 87143] New constructor for WebIntent to be used for delivery : [Attachment 144898] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Greg Billock
<gbillock at google.com>'s request for review:
Bug 87143: New constructor for WebIntent to be used for delivery
https://bugs.webkit.org/show_bug.cgi?id=87143

Attachment 144898: Patch
https://bugs.webkit.org/attachment.cgi?id=144898&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144898&action=review


> Source/WebKit/chromium/public/WebIntent.h:54
> +    WEBKIT_EXPORT WebIntent(const WebString& action, const WebString& type,
const WebString& data,

nit: Instead of exporting constructors, please add an exported initialize
method.  This is in the style guide.

> Source/WebKit/chromium/public/WebIntent.h:95
> +    mutable WebMessagePortChannelArray* m_ownedChannels;

I don't think you should add this member variable.  If you have a way to avoid
it, that would be worth considering.