[webkit-reviews] review granted: [Bug 88261] DFG arguments simplification takes unkindly to direct accesses to the arguments register : [Attachment 145642] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 88261: DFG arguments simplification takes unkindly to direct accesses to
the arguments register
https://bugs.webkit.org/show_bug.cgi?id=88261

Attachment 145642: the patch
https://bugs.webkit.org/attachment.cgi?id=145642&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145642&action=review


r=me

> Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:686
> +		   // If the optimization fixpoint has not converged then this
may read locals.
> +		   if (m_fixpointState == FixpointNotConverged)
>		       result.mayBeAccessed = true;

Only necessary if we've predicted arguments here.