[webkit-reviews] review granted: [Bug 88058] Don't crash when re-parenting a removed HTMLMediaElement : [Attachment 145611] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 4 11:38:37 PDT 2012


Eric Carlson <eric.carlson at apple.com> has granted Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 88058: Don't crash when re-parenting a removed HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=88058

Attachment 145611: Patch
https://bugs.webkit.org/attachment.cgi?id=145611&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145611&action=review


> Source/WebCore/ChangeLog:11
> +	   (WebCore::HTMLMediaElement::userCancelledLoad):

It would be good to have a  few words about why this was changed, something
like "Clear the pending load flags because any pending load has been
cancelled."


More information about the webkit-reviews mailing list