[webkit-reviews] review denied: [Bug 88213] [GTK] Memory leaks in DumpRenderTree.cpp : [Attachment 145534] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Sudarsana Nagineni (babu)
<naginenis at gmail.com>'s request for review:
Bug 88213: [GTK] Memory leaks in DumpRenderTree.cpp
https://bugs.webkit.org/show_bug.cgi?id=88213

Attachment 145534: Patch
https://bugs.webkit.org/attachment.cgi?id=145534&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145534&action=review


Looks good, though I think there should be one change...

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:139
> +    g_free(string);

I think it makes sense for this function to accept a const char* as the second
argument and have the caller responsible for cleaning up the string.