[webkit-reviews] review denied: [Bug 78720] [Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES : [Attachment 145574] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 4 06:57:36 PDT 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Roland Takacs
<rtakacs at inf.u-szeged.hu>'s request for review:
Bug 78720: [Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=78720

Attachment 145574: patch
https://bugs.webkit.org/attachment.cgi?id=145574&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145574&action=review


> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:252

> +	   GraphicsContext3D::clearDepth(1);

I don't think you need GraphicsContext3D::

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:274

> +	   GraphicsContext3D::clearDepth(clearDepth);

ditto.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:93
> -	       ::glTexImage2D(GL_TEXTURE_2D, 0, GL_DEPTH_STENCIL_OES, width,
height, 0, GL_DEPTH_STENCIL_OES, GL_UNSIGNED_INT_24_8_OES, 0);
> +	       ::glTexImage2D(GL_TEXTURE_2D, 0, m_internalColorFormat, width,
height, 0, colorFormat, pixelDataType, 0);

This seems wrong. m_internalColorFormat is equivalent to GL_DEPTH_STENCIL_OES?
I suggest we simply not allow this code-path if GL_DEPTH_STENCIL_OES is not
defined, or something to that effect.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:236
> +#if !defined (QT_OPENGL_ES_2)

Let's switch to USE(OPENGL_ES_2) in this file while we're at it.


More information about the webkit-reviews mailing list