[webkit-reviews] review granted: [Bug 88179] Hit ASSERT when editing attribute value in Element in SVG Document : [Attachment 145467] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 4 05:02:53 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 88179: Hit ASSERT when editing attribute value in Element in SVG Document
https://bugs.webkit.org/show_bug.cgi?id=88179

Attachment 145467: Patch
https://bugs.webkit.org/attachment.cgi?id=145467&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145467&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:584
>      toHTMLElement(parsedElement.get())->setInnerHTML("<span " + text +
"></span>", ec);

Now that you use createHTMLElement, you don't need this cast.


More information about the webkit-reviews mailing list