[webkit-reviews] review denied: [Bug 88210] Expose layoutTestController as testRunner : [Attachment 145512] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 4 00:12:46 PDT 2012


Darin Adler <darin at apple.com> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 88210: Expose layoutTestController as testRunner
https://bugs.webkit.org/show_bug.cgi?id=88210

Attachment 145512: Patch
https://bugs.webkit.org/attachment.cgi?id=145512&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good for DumpRenderTree and TestShell, but to handle WebKitTestRunner, we
also need a change to LayoutTestController::makeWindowObject in
Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp. Since this adds
a test, we’ll start seeing failures if you don’t add that, so review-.


More information about the webkit-reviews mailing list