[webkit-reviews] review granted: [Bug 88204] Remove SelectorQueryCacheEntry from SelectorQuery.h : [Attachment 145501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 3 22:02:28 PDT 2012


Hajime Morrita <morrita at google.com> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 88204: Remove SelectorQueryCacheEntry from SelectorQuery.h
https://bugs.webkit.org/show_bug.cgi?id=88204

Attachment 145501: Patch
https://bugs.webkit.org/attachment.cgi?id=145501&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145501&action=review


> Source/WebCore/dom/SelectorQuery.cpp:187
> +    SelectorQuery* selectorQueryPtr = selectorQuery.get();

Don't use abbreviations like Ptr. FooPointer or rawFoo would be nicer.


More information about the webkit-reviews mailing list