[webkit-reviews] review granted: [Bug 88182] [WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places : [Attachment 145471] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Andy Estes <aestes at apple.com>'s request
for review:
Bug 88182: [WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places
https://bugs.webkit.org/show_bug.cgi?id=88182

Attachment 145471: Patch
https://bugs.webkit.org/attachment.cgi?id=145471&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145471&action=review


> Source/WebKit2/Shared/mac/WebEventFactory.h:45
> +#if USE(APPKIT)
>      static WebMouseEvent createWebMouseEvent(NSEvent *event, NSView
*windowView);
>      static WebWheelEvent createWebWheelEvent(NSEvent *event, NSView
*windowView);
>      static WebKeyboardEvent createWebKeyboardEvent(NSEvent *event, NSView
*windowView);
> +#endif
>  
>  #if ENABLE(GESTURE_EVENTS)
>      static WebGestureEvent createWebGestureEvent(NSEvent *event, NSView
*windowView);

It seems like the USE(APPKIT) should go all the way down to include the
ENABLE(GESTURE_EVENTS).