[webkit-reviews] review granted: [Bug 86214] Fix and enable WebGL for WebKit2 on Qt : [Attachment 145409] patch for review.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 86214: Fix and enable WebGL for WebKit2 on Qt
https://bugs.webkit.org/show_bug.cgi?id=86214

Attachment 145409: patch for review.
https://bugs.webkit.org/attachment.cgi?id=145409&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145409&action=review


OK, this is great! only some minor nitpicks.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:115
> +	       return;

Extra line after return

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:117
> +    }

Extra line after brace. you can do an early return and avoid the else

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:119
> +	 else {

bad indentation

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:296
> +	   m_frontBufferGraphicsSurface = 0;
> +	   m_backBufferGraphicsSurface = 0;

= 0 --> .clear()

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:488
> +    if (!m_canvasNeedsDisplay)
> +	   return;
> +    if (!m_canvasPlatformLayer)
> +	   return;

Extra lines after return;