[webkit-reviews] review granted: [Bug 87896] Large number constant in TransformationMatrix::projectPoint overflows FractionalLayoutUnits with sub-pixel layout enabled : [Attachment 145389] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 15:52:26 PDT 2012


James Robinson <jamesr at chromium.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 87896: Large number constant in TransformationMatrix::projectPoint
overflows FractionalLayoutUnits with sub-pixel layout enabled
https://bugs.webkit.org/show_bug.cgi?id=87896

Attachment 145389: Patch
https://bugs.webkit.org/attachment.cgi?id=145389&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145389&action=review


> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:579
> +	   const int kLargeNumber = 100000000 / kFixedPointDenominator;

style not: WebKit style for constants is to name them the same way all other
variables are named, not kBlahBlah


More information about the webkit-reviews mailing list