[webkit-reviews] review denied: [Bug 86214] Fix and enable WebGL for WebKit2 on Qt : [Attachment 145373] patch for review.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 13:49:28 PDT 2012


Zeno Albisser <zeno at webkit.org> has denied Zeno Albisser <zeno at webkit.org>'s
request for review:
Bug 86214: Fix and enable WebGL for WebKit2 on Qt
https://bugs.webkit.org/show_bug.cgi?id=86214

Attachment 145373: patch for review.
https://bugs.webkit.org/attachment.cgi?id=145373&action=review

------- Additional Comments from Zeno Albisser <zeno at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145373&action=review


> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:40
> +#include <QWindow>

This needs an #if HAVE(QT5)

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:112
> +	   QWindow* window = new QWindow;

#if HAVE(QT5)


More information about the webkit-reviews mailing list