[webkit-reviews] review requested: [Bug 88109] WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string : [Attachment 145369] Patch with fix

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 88109: WebFrame::_stringByEvaluatingJavaScriptFromString methods don't
handle nil string
https://bugs.webkit.org/show_bug.cgi?id=88109

Attachment 145369: Patch with fix
https://bugs.webkit.org/attachment.cgi?id=145369&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
(In reply to comment #3)
> (From update of attachment 145346 [details])
> Expectation should be empty string. Does nil pass?

I was thinking about this as I was out at lunch, realizing that the test was
wrong.	The test was "passing", but shouldn't.	I was assuming that
run-test-webkit-api built the tests before running.  Therefore I wasn't testing
the new code.  Built and tested this patch.  It works as expected.