[webkit-reviews] review granted: [Bug 87428] Indenting a paragraph that begins with a link 3 times breaks the paragraph into two paragraphs : [Attachment 145345] Patch (with change from comment 5)

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Shezan Baig
<shezbaig.wk at gmail.com>'s request for review:
Bug 87428: Indenting a paragraph that begins with a link 3 times breaks the
paragraph into two paragraphs
https://bugs.webkit.org/show_bug.cgi?id=87428

Attachment 145345: Patch (with change from comment 5)
https://bugs.webkit.org/attachment.cgi?id=145345&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145345&action=review


> Source/WebCore/ChangeLog:13
> +	   maintained in the clone. The divergence in depth broke the paragraph

> +	   into two paragraphs because the next sibling was inserted outside
the
> +	   blockquote that was created for the indentation.

Perfect! In general, change log is a good place to describe what caused a bug
and how you fixed it.
It'll allow reviewers to understand the problem and assess the correctness of
your fix with ease.
It also helps someone else (or ourselves) needing understand your code in the
future :).