[webkit-reviews] review granted: [Bug 88110] Prepare table collapsed border computation to support mixed directionality on row group : [Attachment 145340] Proposed preparation. Comments on naming more than welcome.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 1 12:06:51 PDT 2012
Ojan Vafai <ojan at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 88110: Prepare table collapsed border computation to support mixed
directionality on row group
https://bugs.webkit.org/show_bug.cgi?id=88110
Attachment 145340: Proposed preparation. Comments on naming more than welcome.
https://bugs.webkit.org/attachment.cgi?id=145340&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145340&action=review
> Source/WebCore/ChangeLog:14
> + This change add the concept of adjoining borders in the table
direction so that we can safely
s/add/adds
> Source/WebCore/rendering/RenderTableSection.h:127
> + // These methods handle mixed directions between table and sections.
Meh. This is a what comment. That will be clear once you do your followup
patch. No need to add a comment saying it.
More information about the webkit-reviews
mailing list