[webkit-reviews] review granted: [Bug 87969] [chromium] DataTransferItem.webkitGetAsEntry() should synchronously return entry : [Attachment 145083] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 87969: [chromium] DataTransferItem.webkitGetAsEntry() should synchronously
return entry
https://bugs.webkit.org/show_bug.cgi?id=87969

Attachment 145083: Patch
https://bugs.webkit.org/attachment.cgi?id=145083&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145083&action=review


>
Source/WebCore/Modules/filesystem/chromium/DataTransferItemFileSystemChromium.c
pp:80
> +    // FIXME: This involves synchronous file operation. We need to pass file
type data when we dispatch drag event.

If the file on disk changes during the drag, should calls to webkitGetAsEntry()
return current information?  If so, you probably can't do this optimization.