[webkit-reviews] review granted: [Bug 88104] rename -webkit-flex-order to -webkit-order : [Attachment 145329] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 10:13:15 PDT 2012


Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 88104: rename -webkit-flex-order to -webkit-order
https://bugs.webkit.org/show_bug.cgi?id=88104

Attachment 145329: Patch
https://bugs.webkit.org/attachment.cgi?id=145329&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145329&action=review


> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:149
> +    int m_order;

It's a bummer that we use so many bits for this. :( What do we do for z-index?
Also, per-spec, isn't this a float now? Obviously, none of these changes would
happen in this patch. Just bringing it up since I'm noticing the code.


More information about the webkit-reviews mailing list