[webkit-reviews] review granted: [Bug 87800] [GTK] Add a new and reusable Geoclue-based geolocation provider in WebCore : [Attachment 145321] Patch proposal

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 87800: [GTK] Add a new and reusable Geoclue-based geolocation provider in
WebCore
https://bugs.webkit.org/show_bug.cgi?id=87800

Attachment 145321: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=145321&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145321&action=review


Please consider changing the return in geoclueClientSetRequirementsCallback
before landing.

> Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.cpp:66
> +    if (error) {
> +	   provider->errorOccurred(error->message);
> +	   g_error_free(error);
> +	   return;
> +    }

This could be an early return, or remove the return, because there's nothing to
do if there isn't an error