[webkit-reviews] review denied: [Bug 87679] Nested CSS flexbox renders incorrectly : [Attachment 145134] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 09:37:40 PDT 2012


Ojan Vafai <ojan at chromium.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 87679: Nested CSS flexbox renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=87679

Attachment 145134: Patch
https://bugs.webkit.org/attachment.cgi?id=145134&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Yeah, I saw that. I should have removed the r?. I was working on it last night.
It turns out to be tricky to fix. Different uses of overrideHeight seem to
include or not incude border+padding. Making the same causes more tests to fail
for reasons I don't understand. :(


More information about the webkit-reviews mailing list