[webkit-reviews] review denied: [Bug 87842] [WK2-Gtk]Compilation errors with flag CONTEXT_MENUS=0 : [Attachment 145217] updated.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 09:14:01 PDT 2012


Martin Robinson <mrobinson at webkit.org> has denied chandra shekar vallala
<chandra.vallala at motorola.com>'s request for review:
Bug 87842: [WK2-Gtk]Compilation errors with flag CONTEXT_MENUS=0
https://bugs.webkit.org/show_bug.cgi?id=87842

Attachment 145217: updated.patch
https://bugs.webkit.org/attachment.cgi?id=145217&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145217&action=review


> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:28
>  #include "config.h"
> +
>  #include "WebContextMenuProxyGtk.h"

Okay, this a serious nit pick, but we don't typically put a newline here. If
you were a committer, I'd just have you fix it and land yourself. I don't
believe you are though, so do you mind uploading a new patch? Really appreciate
it!


More information about the webkit-reviews mailing list