[webkit-reviews] review granted: [Bug 87738] Make TextureMapper work with GraphicsSurface. : [Attachment 145306] patch for review. - fixed issues as commented before.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 09:04:32 PDT 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has granted Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 87738: Make TextureMapper work with GraphicsSurface.
https://bugs.webkit.org/show_bug.cgi?id=87738

Attachment 145306: patch for review. - fixed issues as commented before.
https://bugs.webkit.org/attachment.cgi?id=145306&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145306&action=review


LGTM with minor nitpicks

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:41
> +    std::swap(m_backBufferGraphicsSurfaceData,
m_currentBufferGraphicsSurfaceData);

current -> front

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h:56
> +    uint32_t m_textureId;

Id -> ID


More information about the webkit-reviews mailing list