[webkit-reviews] review canceled: [Bug 87732] [EFL] Enable SHADOW_DOM flag : [Attachment 145291] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 07:03:06 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has canceled Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 87732: [EFL] Enable SHADOW_DOM flag
https://bugs.webkit.org/show_bug.cgi?id=87732

Attachment 145291: Patch
https://bugs.webkit.org/attachment.cgi?id=145291&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Simplify patch thanks to dependency bugs.

Does anyone know why it does not build for the GTK port?
I added "JSGenerateToJSObject" extended attribute to ShadowRoot.idl so that a
toJS() method is generated for JSShadowRoot. This works fine on EFL port but
the GTK port gets a linking error for the new toJS() method. I'm assuming some
Makefile needs to be tweaked somehow?


More information about the webkit-reviews mailing list