[webkit-reviews] review granted: [Bug 88071] [BlackBerry] Add end editing handling into AutofillManager : [Attachment 145261] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 04:13:30 PDT 2012

Rob Buis <rwlbuis at gmail.com> has granted Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 88071: [BlackBerry] Add end editing handling into AutofillManager

Attachment 145261: Patch

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145261&action=review

Looks good.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:44
> +    void didEndEditing(HTMLInputElement*);

Since other methods use TextField in the name, and we call it from 
EditorClientBlackBerry::textFieldDidEndEditing, you should probably add
TextField in this function too.

More information about the webkit-reviews mailing list