[webkit-reviews] review granted: [Bug 79682] http://shinydemos.com/clock/ doesn't seem to work : [Attachment 145100] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 01:16:31 PDT 2012


Nikolas Zimmermann <zimmermann at kde.org> has granted Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 79682: http://shinydemos.com/clock/ doesn't seem to work
https://bugs.webkit.org/show_bug.cgi?id=79682

Attachment 145100: Patch
https://bugs.webkit.org/attachment.cgi?id=145100&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145100&action=review


> Source/WebCore/rendering/svg/SVGResourcesCache.cpp:157
> +    // SVGInlineText cannot have resources.

I'd leave the static inline bool renderercanHaveResources, instead of
replicating the comment. It should have no run-time overhead and reads better
IMHO.


More information about the webkit-reviews mailing list