[webkit-reviews] review granted: [Bug 88049] Layout not updated after setting -webkit-line-clamp to none : [Attachment 145222] Mark blocks for layout and clear truncation when line-clamp changes to none

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted mitz at webkit.org's request for
review:
Bug 88049: Layout not updated after setting -webkit-line-clamp to none
https://bugs.webkit.org/show_bug.cgi?id=88049

Attachment 145222: Mark blocks for layout and clear truncation when line-clamp
changes to none
https://bugs.webkit.org/attachment.cgi?id=145222&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145222&action=review


> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:153
> +void RenderDeprecatedFlexibleBox::styleWillChange(StyleDifference diff,
const RenderStyle *newStyle)

* on the wrong side.

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:987
> +void RenderDeprecatedFlexibleBox::clearLineClamp()

nit: Can this code be shared with
http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/Web
Core/rendering/RenderDeprecatedFlexibleBox.cpp&exact_package=chromium&q=markPos
itionedObjectsForLayout&type=cs&l=883 to avoid duplication.

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:995
> +	       || (child->style()->height().isAuto() && child->isBlockFlow()))
{

Do we want to use logicalHeight here ?

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:996
> +	       child->setChildNeedsLayout(true);

I think we just need to MarkOnlyThis in the second argument.