[webkit-reviews] review denied: [Bug 87668] LayoutTests/fast/html/tab-order.html should set to false "WebKitTabToLinksPreferenceKey" LayoutTestController setting : [Attachment 144801] patch v3 (removed EFL related part)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 00:20:06 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 87668: LayoutTests/fast/html/tab-order.html should set to false
"WebKitTabToLinksPreferenceKey"  LayoutTestController setting
https://bugs.webkit.org/show_bug.cgi?id=87668

Attachment 144801: patch v3 (removed EFL related part)
https://bugs.webkit.org/attachment.cgi?id=144801&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144801&action=review


> LayoutTests/fast/html/tab-order.html:5
> +	   if (window.layoutTestController)
> +	      
layoutTestController.overridePreference('WebKitTabToLinksPreferenceKey',
false);

This should be done in
http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChr
ome.cpp#L205.


More information about the webkit-reviews mailing list